Conversation
|
This looks amazing 👍 Thanks for your great addition 👍 !! |
|
#17 now contains a fix for an issue I discovered yesterday with this PR. Sorry that they're so intertwined. Let me know if I can help. I won't have time this weekend, so feel free to merge to your likings. |
|
Hey, For this example consider the following image In your implementation you are adding baseline constraint for button 2 in relation to 1, and button 3 in relation to 2, etc.. The following is a po of the constraints added in UIStackView: I think we should consider implementing the same idea as with UIStackView. What is your input on this? |
|
@Thomvis Hey, I will be trying to merge both your great PR's this weekend. About my last question. If you dont have free time, I can totally tackle it. |
|
@oarrabi sorry, but I won't have time soon to improve this further. I do hope that we can eventually merge more changes from https://github.com/Thomvis/OAStackView back to this repo, but I understand that this will take time from me (if you agree with those changes ;)). |
|
Thanks for the addition, I added some specs and merged this PR, Wonderfull work! |

I am working on adding baseline align support, because I needed it. This requires a bit of a change in the way the alignment strategies are called, because the alignment is between views and not between the view and the stack view.
I'm looking for feedback on the following points: