renol - Technical Training by renol-odoo · Pull Request #1170 · odoo/tutorials

renol-odoo · 2026-02-16T09:41:34Z

Hi, first commit here!

robodoo · 2026-02-16T09:41:37Z

blse-odoo

It is a good start, congrats on your first PR!
I noticed you used very short commit messages, did you have a look at the git guidelines? Just to get familiar with the process, I think would be better to try to follow them a bit

chapter2_estate/__manifest__.py

chapter1_firstmodule/__manifest__.py

- Deleting module 'chapter1_firstmodule' - Moving module 'chapter2_estate' to 'estate' as it will be used through all chapters

Fixing `estate_property_action` id error on module installation due to wrong order in `__manifest__.py`

chapter2_estate/models/estate_property.py

estate/models/estate_property_offer.py

estate/models/estate_property.py

blse-odoo

It is looking good!
There is one bug: if user tries to refuse an offer, there is a crash 😮
(and like we said, it fails to start from a fresh db)

estate/models/estate_property_tag.py

estate/views/estate_property_tag_views.xml

renol-odoo · 2026-02-19T12:32:18Z

I failed to reproduce the bug mentioned above (crash on refused offer). Let me know if it is still there or in which conditions it is happening... 🧐

blse-odoo · 2026-02-19T12:35:48Z

I think it is fixed by 121e523#diff-8000c23a2907f34f0cc387be9dc4178411fda81b674724854bd4d048f9e11b16L50

blse-odoo

This looks good 👍

blse-odoo · 2026-02-19T13:16:31Z

estate/models/estate_property.py

+    def _unlink_if_new_or_canceled(self):
+        for record in self:
+            if record.state not in ['new', 'canceled']:
+                raise exceptions.UserError('Cannot delete a property with offers or that is sold!')


I'm not sure what is causing the following error with these steps:

Create a property and save it

Add an offer and save

Cancel the property

Delete the property (confirm delete) → This causes an error

Once an offer has been linked to a property, the property cannot be deleted (even is state=canceled) because of the forgein key constraint in the DB. I've added an error message in 72992f8 to avoid the crash. Another option is to delete the property AND the offer(s) linked to it

Add/customize the following wiews : - property list - property search - property form

'active' and 'garden_orientation' fields were not creating in the DB due to comma at end of line

Implementing new property related models : - Property type: M2O - Property tags: M2M - Property offers: O2M

- Property total area auto computed - Best offer selection - Offer validity & date auto update - Property garden onchange pre-filling - `partener_id` typo fix

Default value was set on server startup time, using a callable (lambda) set value on record creation.

- Set property as sold/cancel - Set offer as accepted/refused (only one accepted offer per property) - Set buyer and selling price when offer is accepted

- SQL constraints for positive property expected/selling price - SQL constraint for positive offer price - SQL constraints for unique tags/types names - Python constraint to check selling above 90% of expected price

Tuning our views [FIX] estate: tag color in views - Show tags color in property view - Show tags color field in list view

blse-odoo · 2026-02-19T18:43:58Z

estate/models/res_users.py

+from odoo import models, fields
+
+class EstateUser(models.Model):
+    _inherit = "res.users"


You can have a look at the other _inherit = "res.users" in odoo. You may want to adapt the code here to follow the naming convention for the file and the class ;)

Yep, updated and squashed into 52efca0

- Property ondelete method - Offer creation method - Inherited user model and view [FIX] estate: renaming res.user subclass Renaming the user class inheriting from `res.user` to follow conventions

Don't allow to delete canceled propertis that recived offers. Otherwise forgein key constraint clash in DB

Add a new estate_account link module to trigger invoice creation when a property is marked as sold

Adding a kanban view for our properties

Trying to match coding guidelines [FIX] estate_account: remove security folder No need for security file for inherited class

Display smart button to easily acces Invoice(s) linked to a Property and vice versa

[LINT] estate: code polishing 3rd pass

blse-odoo · 2026-02-24T07:57:14Z

awesome_owl/static/src/playground.js

+    html1 = "<div class='text-primary'>some content</div>";
+    html2 = markup("<div class='text-primary'>some content</div>");


I did not find where these html1 and html2 are used, is it just the remains of some experiments around markup and html injection?

Using the markup function like that, in a PR for odoo, should result in the security checks to raise a warning, as it allows to pass any string as the first argument, not just a literal string. So calls to this function is a potential source of injection (in case attackers control the first argument, they can add arbitrary html, for example <script> malicious_code() </script>). In your case this is safe, as you pass a literal string (you control the string as you wrote it).
The preferred way to call markup with a literal string, is to use it like this:

html2 = markup`<div class='text-primary'>some content</div>`;

tuto first commit

017bfa2

renol-odoo added 2 commits February 16, 2026 14:25

chapter3

f0d1b51

chapter4

22b1a88

blse-odoo assigned blse-odoo and unassigned blse-odoo Feb 16, 2026

blse-odoo requested review from blse-odoo February 16, 2026 14:33

chapter5

2317b4d

blse-odoo reviewed Feb 16, 2026

View reviewed changes

chapter2_estate/__manifest__.py Outdated Show resolved Hide resolved

chapter1_firstmodule/__manifest__.py Outdated Show resolved Hide resolved

renol-odoo added 2 commits February 17, 2026 08:04

[MOV] estate: ´chapter2_estate´ renamed into ´estate´

069aec8

- Deleting module 'chapter1_firstmodule' - Moving module 'chapter2_estate' to 'estate' as it will be used through all chapters

[FIX] estate: __manifest__.py data order fix

52e29ea

Fixing `estate_property_action` id error on module installation due to wrong order in `__manifest__.py`

blse-odoo reviewed Feb 17, 2026

View reviewed changes

chapter2_estate/models/estate_property.py Outdated Show resolved Hide resolved

blse-odoo reviewed Feb 17, 2026

View reviewed changes

estate/models/estate_property_offer.py Outdated Show resolved Hide resolved

estate/models/estate_property.py Outdated Show resolved Hide resolved

blse-odoo reviewed Feb 19, 2026

View reviewed changes

estate/models/estate_property_tag.py Outdated Show resolved Hide resolved

estate/views/estate_property_tag_views.xml Show resolved Hide resolved

blse-odoo reviewed Feb 19, 2026

View reviewed changes

renol-odoo added 8 commits February 19, 2026 14:57

[IMP] estate: chapter6 - basic views

5c1a596

Add/customize the following wiews : - property list - property search - property form

[FIX] estate: model attributes fix

449981f

'active' and 'garden_orientation' fields were not creating in the DB due to comma at end of line

[IMP] estate: chapter7 - model relations

9c3cca8

Implementing new property related models : - Property type: M2O - Property tags: M2M - Property offers: O2M

[IMP] estate: chapter8 - computed & onchange

bc56d9a

- Property total area auto computed - Best offer selection - Offer validity & date auto update - Property garden onchange pre-filling - `partener_id` typo fix

[FIX] estate: correct date_availability default

def1c15

Default value was set on server startup time, using a callable (lambda) set value on record creation.

[IMP] estate: chapter9 - buttons

4be4b21

- Set property as sold/cancel - Set offer as accepted/refused (only one accepted offer per property) - Set buyer and selling price when offer is accepted

[IMP] estate: chapter10 - constraints

49d8f41

- SQL constraints for positive property expected/selling price - SQL constraint for positive offer price - SQL constraints for unique tags/types names - Python constraint to check selling above 90% of expected price

[IMP] estate: chapter11 - sprinkles

0647fef

Tuning our views [FIX] estate: tag color in views - Show tags color in property view - Show tags color field in list view

renol-odoo force-pushed the 19.0-server101-renol branch from ce25143 to bfa5035 Compare February 19, 2026 14:17

blse-odoo reviewed Feb 19, 2026

View reviewed changes

renol-odoo added 2 commits February 20, 2026 10:17

[IMP] estate: chapter12 - inheritance

52efca0

- Property ondelete method - Offer creation method - Inherited user model and view [FIX] estate: renaming res.user subclass Renaming the user class inheriting from `res.user` to follow conventions

[FIX] estate: cancel properties delete fix

ff7d4a9

Don't allow to delete canceled propertis that recived offers. Otherwise forgein key constraint clash in DB

renol-odoo added 2 commits February 20, 2026 10:17

[IMP] estate_account: chapter13 - other modules interaction

787585f

Add a new estate_account link module to trigger invoice creation when a property is marked as sold

[IMP] estate: chapter14 - QWeb kanban

e3aa5b0

Adding a kanban view for our properties

renol-odoo force-pushed the 19.0-server101-renol branch from 35461f8 to e3aa5b0 Compare February 20, 2026 09:18

renol-odoo added 2 commits February 22, 2026 09:13

[LINT] estate: chapter15 - code polishing

e3f3feb

Trying to match coding guidelines [FIX] estate_account: remove security folder No need for security file for inherited class

[IMP] estate_account: extra - smart btn Property <-> Invoice(s)

1261527

Display smart button to easily acces Invoice(s) linked to a Property and vice versa

renol-odoo force-pushed the 19.0-server101-renol branch from a0852d1 to 8b7fedd Compare February 22, 2026 08:15

[LINT] estate: code polishing 2nd pass

31b1cf4

[LINT] estate: code polishing 3rd pass

renol-odoo force-pushed the 19.0-server101-renol branch from 8b7fedd to 31b1cf4 Compare February 22, 2026 08:28

[IMP] awesome_owl: chapter1 - components

25ac295

blse-odoo reviewed Feb 24, 2026

View reviewed changes

		html1 = "<div class='text-primary'>some content</div>";
		html2 = markup("<div class='text-primary'>some content</div>");

Comments

Conversation

renol-odoo commented Feb 16, 2026

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

blse-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blse-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

renol-odoo commented Feb 19, 2026

Uh oh!

blse-odoo commented Feb 19, 2026

Uh oh!

blse-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

blse-odoo Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

renol-odoo Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

blse-odoo Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

renol-odoo Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

blse-odoo Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blse-odoo left a comment •

edited

Loading