ahham - Technical Training Estate module

[ahmedhamila]

No description provided.

[robodoo]

[ltinel]

Good job, almost nothing to say 🙂

[ltinel]

@ahmedhamila Regarding your commits:

• Could you create one commit per chapter (no need for a FIX commit, you can just squash the fix with the "main" commit).
• FIX commits are for bug fixes, not linting and formatting (See [1]). You can use CLN or LINT for those (but squashing the commits is better in this case).
• Could you use imperative style for the first line of your commit message? I.e. "add" instead of "added".
• The module name (following [ADD]) can be lower case.

[1] https://www.odoo.com/documentation/master/contributing/development/git_guidelines.html

[ltinel]

Great work 😄

[ltinel]

FYI, if you scroll to the bottom of your PR, you'll find some Runbot links (i.e. the ci/style and ci/tutorial checks), which are failing. If you click on the links, you'll find some suggestions. Could you implement those to make the checks pass?

[ltinel]

Thanks, great work again :)

[ltinel]

Good job :)

[ltinel]

Thanks, great work again :)

[ltinel]

Feel free to mark my comments as "resolved" once you've addressed them :)