Conversation
|
|
MrRose765
changed the title
…er 3 - Server framework 101
ltinel
left a comment
ltinel
left a comment
There was a problem hiding this comment.
Good job :) A few "FYIs", but nothing to say really
Chapter 4 - Security
MrRose765
force-pushed
the
19.0-training-cymo
branch
from
73a4aef to
2aa5be2
Compare
ltinel
left a comment
ltinel
left a comment
There was a problem hiding this comment.
Great work 😄
FYI, if you scroll to the bottom of your PR, you'll find some Runbot links, among which the ci/style check. In there, you'll find a few styling suggestions (typically incorrect use of whitespace or newlines). Could you implement those to make the check pass?
|
Thank you for your feedback !
I don't have access to the runbot at the moment 😔. Sysadmins told me that I have to check with HR... I will try to change asap to pass the checks. |
Chapter 5 - Finally, Some UI To Play With
Chapter 6 - Basic views
MrRose765
force-pushed
the
19.0-training-cymo
branch
from
407eb5d to
d732a5b
Compare
Chapter 7 - Relations Between Models
MrRose765
force-pushed
the
19.0-training-cymo
branch
3 times, most recently
from
6b43021 to
8cd5978
Compare
Chapter 8 - Computed Fields and Onchanges
…se offer. Chapter 9 - Ready For Some Action ?
Chapter 10 - Constraints
MrRose765
force-pushed
the
19.0-training-cymo
branch
from
8cd5978 to
041421a
Compare
- Add Python constraint to ensure selling price is acceptable relative to expected price. - Add SQL constraints for unique property names and positive prices. - Add decorations (colors) to the property list view based on status. - Add 'Offers' stat button to the property form view. - Set default ordering for property types and tags. Chapter 11 - Add The Sprinkles
MrRose765
force-pushed
the
19.0-training-cymo
branch
from
041421a to
5856ab1
Compare
Chapter 12 - Inheritance
Chapter 13 - Interact With Other Modules
Chapter 14 - A brief history of QWeb
MrRose765
force-pushed
the
19.0-training-cymo
branch
from
5856ab1 to
9231b81
Compare
awesome_owl/static/src/card/card.js
Outdated
| export class Card extends Component { | ||
| static template = "awesome_owl.Card"; | ||
| static props = { | ||
| title: { type: String, required: true }, |
There was a problem hiding this comment.
I don't think there's any support for required 😅 Props are required by default. You can, however, make props optional via optional: true.
| title: { type: String, required: true }, | |
| title: String, |
There was a problem hiding this comment.
| <?xml version="1.0" encoding="UTF-8" ?> | ||
| <templates xml:space="preserve"> | ||
| <t t-name="awesome_owl.TodoItem"> | ||
| <div t-att-class="props.todo.isCompleted ? 'text-decoration-line-through' : ''"> |
There was a problem hiding this comment.
I think the line-through should only apply to the id and description, but not the checkbox nor the remove button
| onChanged() { | ||
| this.props.toggleState(this.props.todo.id); | ||
| } |
There was a problem hiding this comment.
I'm fine with this, but I'd do the same for both methods: either call both of them directly in the view (and remove this), or call both of them here (and simplify the call in the view).
Discover the web framework - Chapter 1 - Owl components
MrRose765
force-pushed
the
19.0-training-cymo
branch
from
47e5510 to
f65151f
Compare
Tutorial - Define module data
Tutorials - Restrict access to data
3 participants
No description provided.