fix: fail fast on unwritable Docker DB path#28
Merged
Conversation
Fail fast with actionable diagnostics when the SQLite DB path is not writable, including existing read-only database files. Preserve valid SQLite file: URIs and memory DSNs, and update Docker bind-mount guidance to use recursive chown. Follow-up to #22.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preflightDatabasePath()before SQLite init to detect unwritable DB paths with actionable guidance instead of opaque SQLite OOM/pragma errorsonwatch.dbfile:/...?.andmode=memory) and add regression tests for URI-based pathschown -R 65532:65532)Follow-up to #22.
Test plan
go test -race ./internal/store/... -run "PreflightDatabasePath|StoreNew_SQLiteFileURI" -vgo test -race ./... -count=1go vet ./.../data/onwatch.db/data/onwatch.db(0444): fails fast withdatabase file is not writable+ remediation hint