Performance fix for long documents in 1.2.x branch#577
Open
mwidner wants to merge 2 commits intoopenannotation:v1.2.xfrom
Open
Performance fix for long documents in 1.2.x branch#577mwidner wants to merge 2 commits intoopenannotation:v1.2.xfrom
mwidner wants to merge 2 commits intoopenannotation:v1.2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off openannotation/xpath-range#9
@tilgovi As requested, here's a PR with the changes. They made a massive difference in performance for me. I did not update the manifest or tests, or remove the Util.flatten routine. I'm lazy like that. ;)