fix: send the backchannel logout event only if a session exists#2410
Draft
fschade wants to merge 1 commit intoopencloud-eu:mainfrom
Draft
fix: send the backchannel logout event only if a session exists#2410fschade wants to merge 1 commit intoopencloud-eu:mainfrom
fschade wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
7 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The backchannel logout event should only be send if a session is known/identified, if not (only the subject is known) we wait till the oidc token expires. The behavior is still not perfect, this is open for discussion how we handle such cases, cc: @rhafer
Related Issue
Motivation and Context
The logout event was sent to all clients even if the session still existed in the IDP, which resulted in the "re-login" page being displayed in the web client even though the session was still active.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: