Make MaterialFilter support void material#3767
Open
GuySten wants to merge 4 commits intoopenmc-dev:developfrom
Open
Make MaterialFilter support void material#3767GuySten wants to merge 4 commits intoopenmc-dev:developfrom
GuySten wants to merge 4 commits intoopenmc-dev:developfrom
Conversation
GuySten
changed the title
GuySten
force-pushed
the
void-material
branch
from
96df6f4 to
bc52df7
Compare
yardasol
reviewed
Feb 4, 2026
Comment on lines
+31
to
+42
| tally1 = openmc.Tally() | ||
| tally1.filters = [cell_filter] | ||
| tally1.scores = ['flux'] | ||
|
|
||
| tally2 = openmc.Tally() | ||
| tally2.filters = [material_filter] | ||
| tally2.scores = ['flux'] | ||
|
|
||
| model.tallies.append(tally1) | ||
| model.tallies.append(tally2) | ||
|
|
||
| return model |
Contributor
There was a problem hiding this comment.
Very nice design here for testing void material tallies :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently it is not possible to automatically tally void regions.
This PR extend MaterialFilter to support void material.
This is done to simplify generation of multigroup xs data for random ray (#3723).
Checklist