Skip adding methods already provided by a superclass#983
Open
Jenson3210 wants to merge 3 commits intomainfrom
Open
Skip adding methods already provided by a superclass#983Jenson3210 wants to merge 3 commits intomainfrom
Jenson3210 wants to merge 3 commits intomainfrom
Conversation
When a class extends a superclass that already has the method implementation, AddMissingMethodImplementation should not add the method again. Reproduces moderneinc/customer-requests#1862
AddMissingMethodImplementation now walks up the superclass chain to check if the method is already inherited, avoiding unnecessary duplicate method additions to classes like HikariDataSource subclasses. Fixes moderneinc/customer-requests#1862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddMissingMethodImplementationnow checks the superclass hierarchy before adding a methodProblem
When running the Spring Boot 4 migration recipe,
isWrapperFor,unwrap, andgetParentLoggermethods were being added to classes that extend superclasses (e.g.,HikariDataSource,SnowflakeBasicDataSource) which already provide these methods. The recipe only checked the class's own body for existing methods, not the inherited ones.Solution
Walk up the
getSupertype()chain inAddMissingMethodImplementationand check if any superclass already has a matching method viagetMethods(). If so, skip adding the method.Test plan
Existing tests pass
New test added:
skipWhenSuperclassAlreadyHasMethod— verifies that a subclass extending a superclass with the method is left unchangedFixes moderneinc/customer-requests#1862