Optimize private-org-sync retry fetch operations

[petr-muller]

• Skip --tags on retry fetches since tags are already fetched on the initial attempt
• Use --deepen instead of --depth for retry fetches to avoid re-downloading already-fetched commits

🤖 Generated with Claude Code

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eee080f7-7cd3-490f-8a7b-47ef0e703d75

📥 Commits

Reviewing files that changed from the base of the PR and between 396e6b0 and 5137018.

📒 Files selected for processing (2)

• cmd/private-org-sync/main.go
• cmd/private-org-sync/main_test.go

---

Walkthrough

Added a configurable fetchOptions struct and extended makeFetch to accept it; fetch command assembly now conditionally includes tags and chooses between --deepen and --depth based on useDeepen, with deepen computed as 2^(expDepth-1). mirror() and tests updated to pass and expect the new behavior.

Changes

Cohort / File(s)	Summary
Fetch command and logic cmd/private-org-sync/main.go	Added fetchOptions (withTags, useDeepen), extended makeFetch signature, changed fetch command construction to optionally include --tags, and switch between --deepen=<n> (when useDeepen true) and --depth=<n>; added logging for depthArg and updated rev-parse error text.
Tests cmd/private-org-sync/main_test.go	Updated TestMirror expectations to reflect --deepen usage with progression (2,4,8,16,32) instead of previous --depth values; retained unshallow fetch expectations and overall control flow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Command failed

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign jmguzik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

This PR optimizes private-org-sync’s retry fetch behavior during mirror operations by reducing redundant data transfer when a push fails due to a shallow clone.

Changes:

• Skip --tags on retry fetches (tags are fetched on the initial attempt).
• Use --deepen for retry fetches instead of increasing --depth, avoiding re-downloading already-fetched commits.
• Update unit tests to reflect the new fetch command sequence.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/private-org-sync/main.go	Adjusts fetch construction to support “initial fetch with tags + depth” and “retry fetches with deepen, without tags”.
cmd/private-org-sync/main_test.go	Updates expected mocked git invocations for retry fetches to use --deepen and omit --tags.

Comments suppressed due to low confidence (1)

cmd/private-org-sync/main.go:463

• The log message references rev-parse --is-shallow-repo but the command being run is rev-parse --is-shallow-repository. This mismatch can confuse debugging; please update the message to the exact flag name.

			logger.Error(message)
			logger.Error("`rev-parse --is-shallow-repo` likely not supported by used git")
			return nil, fmt.Errorf("%s", message)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[petr-muller]

/hold

reviews make sense

[petr-muller]

/hold cancel

[petr-muller]

/test images

[openshift-ci-robot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

[openshift-ci]

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/breaking-changes	5137018	link	false	/test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.