Revert "TRT-2549: Revert "Add a serial e2e for accept-risks""

[hongkailiu]

Reverts #1319

[openshift-ci-robot]

@hongkailiu: This pull request references TRT-2549 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Reverts #1319

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

Centralized CVO defaults were added (internal + external packages); code was refactored to use those constants instead of literals; a new end-to-end AcceptRisks test and related test utilities were added; test suite qualifiers and an openshift-tests JSON entry were updated.

Changes

Cohort / File(s)	Summary
Constants pkg/internal/constants.go, pkg/external/constants.go	Added centralized CVO-related constants in pkg/internal and re-exported them from pkg/external (namespace, clusterVersion name, deployment name, container name, conditional update condition type).
Core refactor to use constants lib/resourcebuilder/apps.go, pkg/cvo/sync_worker.go, pkg/start/start.go, test/cvo/cvo.go	Replaced hard-coded CVO namespace/cluster-version/deployment/container identifiers with the new centralized constants; removed or replaced local literals/defaults.
New end-to-end CVO test test/cvo/accept_risks.go	Added comprehensive AcceptRisks e2e test that modifies ClusterVersion, collects ConditionalUpdates, applies AcceptRisks, and validates status/release behavior with setup/teardown and polling.
Test utilities test/util/util.go	Added feature-gate helpers IsTechPreviewNoUpgrade and SkipIfNotTechPreviewNoUpgrade, plus FauxinnatiAPIURL constant and a Gomega import alias.
Test suite metadata & qualifiers .openshift-tests-extension/openshift_payload_cluster-version-operator.json, cmd/cluster-version-operator-tests/main.go	Inserted a new test entry for "cluster-version-operator should work with accept risks" into the tests JSON; adjusted parallel/serial suite qualifiers to consider Serial label more broadly.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[hongkailiu]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

[openshift-ci]

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed4d9690-0b45-11f1-87fd-e14864a60d45-0

[hongkailiu]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

[openshift-ci]

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8131a350-0b4c-11f1-9b6a-01a988e0484f-0

[hongkailiu]

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2 10

[openshift-ci]

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5e192b30-0b6b-11f1-9747-e8748fa3f217-0

[hongkailiu]

See #1323 (comment)

/verified by "TheAggregatedJob"

/retest-required

[openshift-ci-robot]

@hongkailiu: This PR has been marked as verified by "TheAggregatedJob".

Details

In response to this:

See #1323 (comment)

/verified by "TheAggregatedJob"

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hongkailiu]

/test e2e-hypershift-conformance

[neisw]

/lgtm

/override ci/prow/e2e-hypershift-conformance
failing outside of this pr

[openshift-ci]

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-hypershift-conformance

Details

In response to this:

/lgtm

/override ci/prow/e2e-hypershift-conformance
failing outside of this pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[petr-muller]

/override ci/prow/e2e-hypershift-conformance

[openshift-ci]

@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-hypershift-conformance

Details

In response to this:

/override ci/prow/e2e-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.