-
Notifications
You must be signed in to change notification settings - Fork 151
OCPBUGS-74872: Sort plugin list to make them deterministic #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jhadvig: This pull request references Jira Issue OCPBUGS-74872, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cedf6d4 to
a876b6d
Compare
|
/jira refresh |
|
@jhadvig: This pull request references Jira Issue OCPBUGS-74872, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jhadvig: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
TheRealJon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem
After enabling console plugins (particularly odf-console), the Console Operator gets stuck in a reconciliation loop with repeated console-config ConfigMap updates, causing console pods to restart every few minutes.
Root Cause
Non-deterministic YAML generation in the ConfigMap. Plugin-related data structures weren't consistently ordered, causing the ConfigMap content to vary between reconciliation cycles even when no actual changes occurred.
Solution
Fixed plugin data ordering:
Added retry logic:
Wrap ApplyConfigMap() with retry.RetryOnConflict() to handle concurrent updates
/assign @TheRealJon