OCPBUGS-76319: Makefile: Strip debugging symbols by default

[tchap]

You can still run make STRIP_DEBUGGING_SYMBOLS=false oc to skip that.

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

This pull request introduces a new build-time configuration to control debugging symbol stripping. A STRIP_DEBUGGING_SYMBOLS flag is added to the Makefile with conditional linker flags, and README documentation is updated to explain the feature.

Changes

Cohort / File(s)	Summary
Build Configuration Makefile	Introduces STRIP_DEBUGGING_SYMBOLS flag (defaults to true) and STRIP_DEBUGGING_SYMBOLS_FLAGS variable with -s -w linker options. Extends GO_LD_EXTRAFLAGS to append these flags to the linker configuration for binary optimization.
Documentation README.md	Adds documentation explaining that debugging symbols are excluded by default during builds and provides the command to include them using STRIP_DEBUGGING_SYMBOLS=false.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tchap]

/jira refresh

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

I still need to verify what all needs to be done for this, starting with RPM for now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/retitle OCPBUGS-76319: Strip debugging symbols when releasing oc

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-76319, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We don't want the debug RPM package, so I am setting -w -s in oc.spec directly.

For other cases, oc is being built using the included Dockerfiles, so I updated those as well.

go build is now passed -trimpath also so that there are no absolute file paths in the executable.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/retest

[tchap]

@ardaguclu I greatly simplified the thing as requested, PTAL.

[ardaguclu]

@ardaguclu I greatly simplified the thing as requested, PTAL.

Thank you. It looks good to me. Let's run the payload blocking jobs;

/payload 4.22 nightly blocking
/lgtm
/approve
/hold
until blocking jobs are green.

[openshift-ci]

@ardaguclu: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-upgrade-ovn-single-node
• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-upgrade-fips
• periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade
• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-rt-upgrade
• periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-ovn-conformance
• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2
• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-2of2
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3
• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-upgrade-fips-no-nat-instance
• periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4
• periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/efebbcb0-0b27-11f1-9af8-0484481bd74f-0

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

@sdodson mentioned that these changes could be backported to previous versions. Perhaps, once we land this PR in 4.22 and give it some soak time to catch any regressions, we can backport it down to 4.20?.

[sdodson]

@sdodson mentioned that these changes could be backported to previous versions. Perhaps, once we land this PR in 4.22 and give it some soak time to catch any regressions, we can backport it down to 4.20?.

I don't think we're in a rush. How about four weeks between main and release-4.21, then another four weeks between release-4.21 and release-4.20? We'll still beat most wide adoption of 4.20 with that timeline.

[tchap]

/retest

[ardaguclu]

This can wait until achknowledge-critical-fixes-only requirement is lifted
/hold

[openshift-ci]

@tchap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-serial-1of2	719e848	link	true	/test e2e-aws-ovn-serial-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.