Skip to content

fix: add ipi-install-vsphere-registry to vsphere OVN WINC provision chain#76362

Open
weinliu wants to merge 1 commit intoopenshift:mainfrom
weinliu:fix-winc-vsphere-provision-registry
Open

fix: add ipi-install-vsphere-registry to vsphere OVN WINC provision chain#76362
weinliu wants to merge 1 commit intoopenshift:mainfrom
weinliu:fix-winc-vsphere-provision-registry

Conversation

@weinliu
Copy link
Contributor

@weinliu weinliu commented Mar 16, 2026

Summary

The cucushift-installer-rehearse-vsphere-ipi-ovn-winc-provision chain was missing the ipi-install-vsphere-registry step after ipi-install, causing the image registry to remain without a backing store configured. This resulted in dockercfg secrets not being created in new namespaces, blocking Windows container e2e tests.

Other vSphere provision chains (disconnected, proxy variants) already include this step correctly. This change aligns the OVN WINC chain with the established pattern.

Root cause

  • ipi-install (generic chain) does not configure vSphere image registry storage
  • ipi-install-vsphere-registry is the vSphere-specific step that patches the registry with an NFS backing store
  • Without it, the registry operator stays in a degraded state and dockercfg secrets are never injected into new namespaces

Test

Rehearsed with pull-ci-openshift-openshift-tests-private-release-4.21-debug-winc-vsphere-ipi: the ipi-install-vsphere-registry step succeeded and subsequent Windows e2e tests ran as expected.

…hain

The cucushift-installer-rehearse-vsphere-ipi-ovn-winc-provision chain
was missing the ipi-install-vsphere-registry step after ipi-install,
causing the image registry to remain in Removed/Managed state without
a backing store configured. This resulted in dockercfg secrets not
being created in new namespaces, blocking Windows container e2e tests.

Other vSphere provision chains (disconnected, proxy variants) already
include this step correctly. This change aligns the OVN WINC chain
with the established pattern.
@openshift-ci openshift-ci bot requested review from huali9 and jhou1 March 16, 2026 23:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weinliu
Once this PR has been reviewed and has the lgtm label, please assign jhou1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@weinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-openshift-tests-private-main-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-5.0-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.23-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.22-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.21-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.20-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.19-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.18-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-openshift-tests-private-release-4.16-debug-winc-vsphere-ipi openshift/openshift-tests-private presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.23-amd64-nightly-vsphere-ipi-ovn-winc-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-vsphere-ipi-ovn-winc-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-ipi-ovn-winc-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-vsphere-ipi-ovn-winc-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-vsphere-ipi-ovn-winc-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-ipi-ovn-winc-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-vsphere-ipi-ovn-winc-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-ipi-ovn-winc-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-vsphere-ipi-ovn-winc-f7 N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@weinliu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants