PGProblemEditor: Add option to copy auxiliary files.#2922
Open
somiaj wants to merge 1 commit intoopenwebwork:developfrom
Open
PGProblemEditor: Add option to copy auxiliary files.#2922somiaj wants to merge 1 commit intoopenwebwork:developfrom
somiaj wants to merge 1 commit intoopenwebwork:developfrom
Conversation
When saving a problem in a new location in the PGProblemEditor, add an option to copy auxiliary files or not. Since it is not possible to determine what files are needed, all auxiliary files were copied in all cases. This allows the user to uncheck the "Copy auxiliary files" option to not copy any auxiliary files. The default option is to copy auxiliary files which has not changed. This only allows the user to disable that if they are sure no auxiliary files are needed. This also adds a check so the message about auxiliary files being copied only shows if at least one file was copied.
d53ab59 to
5753522
Compare
Contributor
Author
|
Note, due to the fact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving a problem in a new location in the PGProblemEditor, add an option to copy auxiliary files or not. Since it is not possible to determine what files are needed, all auxiliary files were copied in all cases. This allows the user to uncheck the "Copy auxiliary files" option to not copy any auxiliary files.
The default option is to copy auxiliary files which has not changed. This only allows the user to disable that if they are sure no auxiliary files are needed.
This also adds a check so the message about auxiliary files being copied only shows if at least one file was copied.
@drgrice1 I am unable to figure out how to keep this new option to stay unchecked once a user unchecks it. I used the same setup the "Create backup" option uses with a hidden field, but when I uncheck this new option, and save the file, the page checks it by default again. So I'm unsure what is going on in that case.