Add proper typing @overload to zimscraperlib.image.optimize_xxx methods#273
Merged
Add proper typing @overload to zimscraperlib.image.optimize_xxx methods#273
zimscraperlib.image.optimize_xxx methods#273Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
- Coverage 99.87% 99.63% -0.25%
==========================================
Files 41 41
Lines 2480 2493 +13
Branches 340 346 +6
==========================================
+ Hits 2477 2484 +7
- Misses 1 7 +6
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b853763 to
1893e14
Compare
Collaborator
Author
|
Sorry, I forgot to fix PR number in CHANGELOG, hence the force push |
Collaborator
Author
|
I don't think it lacks tests, this is just a "bug" in coverage report. These methods are "fictive" and never really executed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type hints could be more precise thanks to
@overloadpython feature (see https://typing.python.org/en/latest/spec/overload.html)