Linting: Incorrect import of pytest; use import pytest instead#824
Linting: Incorrect import of pytest; use import pytest instead#824ogenstad merged 1 commit intoinfrahub-developfrom
pytest; use import pytest instead#824Conversation
WalkthroughThis pull request standardizes pytest type annotations across the pytest plugin codebase. Type hints referencing pytest symbols (ExceptionInfo, Item, Parser, Session, Collector, Config, TempPathFactory) have been updated to use the fully-qualified 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
54f3a4c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf1c42af.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-pt013.infrahub-sdk-python.pages.dev |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## infrahub-develop #824 +/- ##
====================================================
- Coverage 81.69% 80.57% -1.12%
====================================================
Files 118 118
Lines 11919 10235 -1684
Branches 2047 1538 -509
====================================================
- Hits 9737 8247 -1490
+ Misses 1553 1457 -96
+ Partials 629 531 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
infrahub_sdk/pytest_plugin/plugin.py (1)
103-103:⚠️ Potential issue | 🟡 MinorPre-existing typo: "infrahub_integraton" and "Integation".
The marker name and description both have typos —
infrahub_integraton(missing 'i') andIntegation(missing 'r'). Since this file is already being touched, it would be a good opportunity to fix them.✏️ Proposed fix
- "infrahub_integraton: Integation test for an Infrahub resource, depends on an Infrahub running instance", + "infrahub_integration: Integration test for an Infrahub resource, depends on an Infrahub running instance",
Why
Reduce number of ignored linting rules.
What changed
Use standard approach for pytest imports
Summary by CodeRabbit
pytest.*namespace, improving consistency and maintainability without affecting functionality.