AO3-5937 "Save" button visible on bookmarks when logged out and on a tag's bookmarks page

[forceofcalm]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-5937

Purpose

Wraps the "save" and "saved" actions for bookmarks in a logged_in? check.

Testing Instructions

I have left a comment for clarification on the JIRA ticket.

Credit

calm (they/them)

[ceithir]

Could you add an integration test covering this fix?

[brianjaustin]

I think these should help with the ERB lint warning (I have not had a chance to test locally though, so some further nudges may be required)

[forceofcalm]

I'm writing the integration test for this now (or at least, trying to), and I've noticed that the Save button is actually an <li> element styled like a button. For accessibility reasons, this should be an actual <button> element. A change like that is out of the scope of this ticket, but should be noted somewhere.

[forceofcalm]

Hi! I have no fucking idea what RuboCop wants from me. I've tried a ton of different indents and it is still upset.

[brianjaustin]

If rubocop and/or erblint is giving me trouble, I usually will run

rubocop -A path/to/file.rb
# or
erblint -A path/to/file.html.erb

That will often do a lot more than we need, so I also use git add -p to selectively add lines to my commit, and then run git checkout path/to/file.rb to avoid changing a bunch of things at once. I sympathise with fighting erblint/rubocop though, so I've pushed what ERB lint seems to want to brianjaustin@6f6f854

[Bilka2]

I've flipped the label back to action needed since the comment about the test still needs addressing

[Bilka2]

The tests don't actually use this step, instead they use the generic "I go to ":

otwarchive/features/step_definitions/web_steps.rb

Lines 27 to 29 in 7474fad

	When /^(?:|I )go to (.+)$/ do |page_name|
	visit path_to(page_name)
	end

This means the tests go to the overall bookmarks index instead of the tag's index and don't fail even if the change in this PR is reverted. If you define this path in paths.rb instead then it should work correctly