You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Shouldn't the main CMakeFile also define CLARABEL_RUST_FEATURES before passing it to the rust_wrapper build? At the moment it gets ignored, which is confusing
Shouldn't the main CMakeFile also define CLARABEL_RUST_FEATURES before passing it to the rust_wrapper build? At the moment it gets ignored, which is confusing
Fair point. I made a minor cleanup in #69, putting it into the main CMakeLists.txt. I also renamed it CLARABEL_CARGO_FEATURES to emphasise that it's the list of features to be passed directly to cargo.
The other features (i.e. CLARABEL_FEATURE_XXX) aren't actually necessary anymore since all are just appending the appropriate cargo options to CLARABEL_CARGO_FEATURES, but I kept them in for backward compatibility. Maybe they are also a bit more convenient when using ccmake or similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.