Create issue package via the --create-issue-package option for convenient issue reporting#210
Draft
jjppp wants to merge 1 commit intopascal-lab:masterfrom
Draft
Create issue package via the --create-issue-package option for convenient issue reporting#210jjppp wants to merge 1 commit intopascal-lab:masterfrom
--create-issue-package option for convenient issue reporting#210jjppp wants to merge 1 commit intopascal-lab:masterfrom
Conversation
…enient issue reporting. Currently we consider `classPath`, `appClassPath`, `inputClasses`, and `outputDir`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
============================================
- Coverage 75.81% 75.60% -0.22%
Complexity 4657 4657
============================================
Files 481 482 +1
Lines 16070 16115 +45
Branches 2199 2203 +4
============================================
Hits 12184 12184
- Misses 3019 3062 +43
- Partials 867 869 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #186 by
classPath,appClassPath,inputClasses, andoutputDir. By default, theoptions.ymlandtai-e.logare included in theoutputDir.package.zipunder four different subdirectories.There's a few things left to be discussed, making this PR a draft that is not ready for merge, including (but not limited to):
package.zipis created at the working directory by default, should we provide options to change its location?-ppis used, should we also pack jvm classes from the system jvm class path?package.zipmight not reflect the original directory structure in the reproter's device, maybe tests should be made to check the reproducibility of the produced package.