Fixes for #1158 and #1310#1312
Open
robgtsoftware wants to merge 2 commits intopatchthecode:masterfrom
Open
Conversation
…hthecode#1158 Changed access modifier to open to allow subclasses to access and create the required view
Added support for scrolling year view to a specified date and a new delegate method to allow for detection of user selection of a given month view. Changed visibility of the extension to provide default protocol implementations so apps using library will benefit. Extended sample app to show new functionality in year view
robgtsoftware
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains two fixes.
First is a fix for #1158 to allow the JTACMonthCell to be programmatically subclassed without a need for a storyboard
Second is for #1310 where I have added two new methods. One for scrolling to a given date in the year view and one for alerting the year view delegate that a month was selected. Extended the year example in the example app to show the new functionality. Also, make sure the default protocol implementations were visible to apps using the library