Fold ohttp relay into mailroom#1409
Merged
spacebear21 merged 4 commits intopayjoin:masterfrom Mar 13, 2026
Merged
Conversation
The internal path dependency on `../ohttp-relay` was the last thing preventing us from publishing payjoin-mailroom to crates.io. This commit folds all relay logic into the mailroom crate so that we can simplify the dependency tree and delete the obsolete ohttp-relay crate in a follow-up.
There are no dependents on the ohttp-relay crate outside of payjoin-mailroom, which now houses all the relay logic.
Collaborator
Pull Request Test Coverage Report for Build 23031061980Details
💛 - Coveralls |
spacebear21
force-pushed
the
fold-ohttp-relay-into-mailroom
branch
2 times, most recently
from
0be5380 to
ff17031
Compare
These were previously necessary for the integration test, but we can now use an actual mailroom instance instead of a custom ohttp_relay listener. The unix socket test wasn't adding much value AFAICT so I deleted it. Unix sockets are supported by the mailroom `listener` parameter but we'd just be testing an external dependency, not internal logic.
spacebear21
force-pushed
the
fold-ohttp-relay-into-mailroom
branch
from
ff17031 to
63e62ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #1361 by folding the ohttp-relay crate into payjoin-mailroom and deleting the now-defunct crate.
The internal path dependency on
../ohttp-relaywas the last thing preventing us from publishing payjoin-mailroom to crates.io, so this PR clears the way for a published release.Authored with Claude
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.