fix treemap rendering issue in firefox#2813
Merged
texodus merged 2 commits intoperspective-dev:masterfrom Dec 2, 2024
Merged
Conversation
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
texodus
approved these changes
Dec 2, 2024
Member
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Perspective does not currently support FireFox (See #2818) and its generally our policy not to merge fixes for unsupported platforms because they are difficult for correctness. However in this case, this fix is correct and trivial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes one of the Firefox issues in #2693, specifically issue #1983
I used string interpolation for the style on the rect element (for x and y) to introduce layout consistency by adding px to the
d.x0andd.y0values. I realized that without this, Firefox ignored some of the values, hence the issue.Pull Request Checklist
Discussions, this PR applies to.