add support for binary protocol for pcpatch#246
Open
cyrilleberger wants to merge 12 commits intopgpointcloud:masterfrom
Open
add support for binary protocol for pcpatch#246cyrilleberger wants to merge 12 commits intopgpointcloud:masterfrom
cyrilleberger wants to merge 12 commits intopgpointcloud:masterfrom
Conversation
added 8 commits
May 26, 2015 10:52
Author
|
I was wondering, is anything else needed? |
Author
|
Not entirely sure why the change I made would cause the errors, but if there is ever any interest in merging I could have a look. |
Author
|
Formatting fixed, and updated to the latest master. "make check" is still passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #85, with a test and update.
Two comments
No idea on how to do differently and if it is a big problem.