test: improve the tests for in_array #21087
Open
+450
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Jan 30, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I'd rather split this test into multiple ones because trying to verify that 200 iterations of a foreach is corret is just unreasonable.
jorgsowa
force-pushed
the
test/improve-tests-for-in_array
branch
from
a7dd7b0 to
c64920f
Compare
Contributor
Author
|
Is splitting reference-value data into a separate test appropriate? I added descriptions to each iteration to make the test results easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more detailed descriptions to test iterations so it’s clear what the input is for each iteration. Additionally, I added a new test cases for an arrays containing references and enums.