prototype Pydantic choice support in create_pydantic_model#469
Open
dantownsend wants to merge 1 commit intomasterfrom
Open
prototype Pydantic choice support in create_pydantic_model#469dantownsend wants to merge 1 commit intomasterfrom
create_pydantic_model#469dantownsend wants to merge 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
==========================================
- Coverage 90.84% 90.83% -0.02%
==========================================
Files 104 104
Lines 6913 6915 +2
==========================================
+ Hits 6280 6281 +1
- Misses 633 634 +1
Continue to review full report at Codecov.
|
sinisaos
reviewed
Mar 26, 2022
| if isinstance(column, (Decimal, Numeric)): | ||
| value_type: t.Type = pydantic.condecimal( | ||
| if column._meta.choices: | ||
| value_type: t.Type = column._meta.choices |
Member
There was a problem hiding this comment.
@dantownsend Strings work well. Adding these two lines code becomes compatible with Piccolo Admin (with field propertyTitle).
# pydantic.py line 242
if column._meta.choices:
params["title"] = column._meta.choices.__name__In Piccolo Admin change this line to v-bind:type="property.type" and this line to class Gender(str, enum.Enum): and everything work well in admin and openapi docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related to #467
Just a prototype at the moment.
If a Piccolo column has choices, we can use the choices
Enumas the Pydantic type. For example:It would become this Pydantic model:
The problem is the JSON schema it generates is quite complex, and Piccolo Admin doesn't currently understand
$refvalues:So the options are:
$refPydanticModelclass #331, which would add a new API for creating Pydantic models.create_pydantic_modelwill still be supported, and used by Piccolo admin for now, but we can migrate to this new API at a later date.