(Sonar) Fixed finding: "String literals should not be duplicated"

[pixee-standardchartered]

Remediation

This change fixes "String literals should not be duplicated" (id = java:S1192) identified by Sonar.

Details

This change defines a constant for duplicated literal expression values, simplifying the refactoring process and mitigating the risk of overlooking any values during updates.

Our changes look something like this:

+    private static final String EXCEPTION_AT = "Exception at";

-       LOG.error("Exception at", ex)
+       builder.add(EXCEPTION_AT)  

-       LOG.error("Exception at", ex)
+       builder.add(EXCEPTION_AT)  

-       LOG.error("Exception at", ex)
+       builder.add(EXCEPTION_AT)  

More reading

• https://rules.sonarsource.com/java/RSPEC-1192/

I have additional improvements ready for this repo! If you want to see them, leave the comment:

@pixeebot next

... and I will open a new PR right away!

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: sonar:java/define-constant-for-duplicate-literal-s1192

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[pixee-standardchartered]

I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it?

If this change was not helpful, or you have suggestions for improvements, please let me know!

[pixee-standardchartered]

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

[pixee-standardchartered]

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.