Use DEFAULT_DESTINATION_REF constant in order_request.py#1202
Merged
asonnenschein merged 2 commits intoadrian/default-destinationsfrom Nov 12, 2025
Merged
Use DEFAULT_DESTINATION_REF constant in order_request.py#1202asonnenschein merged 2 commits intoadrian/default-destinationsfrom
asonnenschein merged 2 commits intoadrian/default-destinationsfrom
Conversation
1 task
Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on default destination support implementation
Use DEFAULT_DESTINATION_REF constant in order_request.py
Nov 12, 2025
asonnenschein
approved these changes
Nov 12, 2025
asonnenschein
added a commit
that referenced
this pull request
Nov 17, 2025
* default destinations sdk and cli support * add tests * yapf * fix type issues * fix parameter name * update cli docs * Update planet/subscription_request.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Use DEFAULT_DESTINATION_REF constant in order_request.py (#1202) * Initial plan * Use DEFAULT_DESTINATION_REF constant in order_request.py Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: asonnenschein <3228909+asonnenschein@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Addresses feedback from #1201 (comment #1201 (comment))
Proposed Changes:
For inclusion in changelog (if applicable):
Not intended for changelog:
DEFAULT_DESTINATION_REFconstant fromplanet.clients.destinationsinplanet/order_request.pyinstead of hardcoding'pl:destinations/default'Diff of User Interface
Old behavior:
New behavior:
Both
planet/order_request.pyandplanet/subscription_request.pynow use the same constant, establishing single source of truth.PR Checklist:
(Optional) @mentions for Notifications:
@asonnenschein
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.