Conversation
…rict TQ003 to MSSQL Prevent redundant overlap-retry passes by tracking already-retried SQL states so identical input is never re-linted. Cap per-iteration rule evaluations in the parse-error incremental path for large SQL to avoid quadratic slowdown. Guard TQ003 (empty GO batches) to only fire under the MSSQL dialect. Add unit tests for fix candidate stats and non-MSSQL TQ003 skip. Clarify build_case_anchor_cache ordering with a comment explaining the intentional pre-assignment pattern.
- Document all fix-loop tuning constants with rationale comments - Consolidate three duplicated fallback blocks into try_fallback_fix helper - Clean up profiling: merge two zero-ms cached marks into one - Warn on stderr when --format is used with --fix-only (ignored) - Add 30s wall-clock FIX_LOOP_TIMEOUT as safety net for pathological inputs - Extract complex stop condition into should_stop_large_mostly_unfixable() - Add module-level docs and section markers to lt_002.rs for navigability
- Replace HashSet<String> with hash-based cycle detection (HashSet<u64>) to avoid cloning full SQL strings in fix loop and incremental planner - Sanitize lint-fix API error response to not leak internal details - Add doc comments to public API types: LintFixRuntimeOptions, FixCandidateStats, LintFixExecution, apply_lint_fixes_with_runtime_options - Add debug_assert for blocked-total invariant in collect_fix_candidate_stats - Switch API endpoint to shared multi-pass runtime pipeline and update RF004 test to match cascading multi-pass behavior - Fix pre-existing clippy warnings: collapsible_if in LT002, allow too_many_arguments on LT003/fix.rs functions - Add requires="lint" constraint for --exclude-rules CLI flag - Extract push_current_char helper in parser sanitizer for clarity
- Context section: replace obsolete 15+57 split with current 72-rule one-rule-per-file architecture - Mark all migration phases (0-3) as COMPLETE - Update execution pipeline from "Proposed" to active - Expand Phase 1 rule list to include all migrated families - Condense trailing progress items and link to sqlfluff-gap-matrix.md - Mark resolved risks and success criteria - Update date to 2026-02-21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.