Conversation
…/prefapp/daggerverse into fix/413-fix-error-on-pr-creation
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent errors when creating GitHub PRs via the gh Dagger module by adding retry/delay behavior, and updates the consuming module to a newer pinned version of that dependency.
Changes:
- Update
update-claims-featuresto pin a newerghdaggerverse dependency revision. - Add retry loops around
gh pr createand PR-number lookup inGh.CreatePR. - Add a fixed delay before calling
CreatePRinCommitAndCreatePR.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| update-claims-features/dagger.json | Bumps the pinned gh module revision to pick up the fix. |
| gh/main.go | Adds retry/sleep logic intended to eliminate false-negative PR creation errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
gh/main.go:426
- The final PR link retrieval operation (gh pr view) lacks retry logic. While this operation might be less prone to timing issues since the PR should already exist by this point, adding retry logic here would be more consistent with the approach taken for PR creation and PR ID retrieval, and would make the function more resilient to transient GitHub API issues.
prLink, err := ctr.
WithExec([]string{
"gh", "pr", "view",
"--json", "url",
"--jq", ".url",
strings.TrimSpace(prId),
}).
Stdout(ctx)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #413
Examples