Rewrite in N-API and update libgit2#6
Rewrite in N-API and update libgit2#6savetheclocktower wants to merge 20 commits intopulsar-edit:masterfrom
libgit2#6Conversation
Wasn’t a pressing need, but I wanted some more practice at converting modules that use `nan`.
…and fix issue revealed by failing tests.
2509503 to
1723dfa
Compare
|
The size of the diff should be explained. We used to explicitly vendor Either way, this PR would touch a lot of files; if the submodule approach works, then future |
|
OK, CI currently only tests in Linux. Good to know Linux passes, but I should add Windows to the matrix or else I can't be certain that this is a safe change to make! I'll revisit this tomorrow. |
|
PR #5 has more context about why
|
|
Hey! Got a passing test suite on all platforms. I think some of those Windows bugs had been around for a while. Taking this out of draft! |
git-utilsis failing to build altogether on my work laptop (which runs macOS 26, despite my best efforts), so I figured this was a good time to bumplibgit2.This also adopts the needed rewrite of
git-utilsin N-API; this should probably fix pulsar#1468.The tests pass for me locally, but I'll open this as a draft to start just to see what CI thinks of it on the other platforms.