Skip to content

Remove outdated editable mode warning from docs#17381

Open
mohammed-saalim wants to merge 2 commits intopytorch:mainfrom
mohammed-saalim:remove-outdated-editable-warning
Open

Remove outdated editable mode warning from docs#17381
mohammed-saalim wants to merge 2 commits intopytorch:mainfrom
mohammed-saalim:remove-outdated-editable-warning

Conversation

@mohammed-saalim
Copy link
Contributor

Summary

Removed outdated warning about modules not being importable directly in editable mode, as this issue has been resolved.

Changes

  • Removed the warning section from docs/source/using-executorch-building-from-source.md
  • Direct imports like from executorch.exir import CaptureConfig now work correctly in editable mode

Context

The warning referenced issue #9558 which has since been fixed. The workaround is no longer necessary.

Fixes #11229
Supersedes #11245

cc @larryliu0820 @mergennachin @byjlw

The warning about modules not being importable directly in editable mode
is no longer relevant, as the issue has been resolved. Direct imports like
'from executorch.exir import CaptureConfig' now work correctly in editable mode.

Fixes pytorch#11229
Copilot AI review requested due to automatic review settings February 11, 2026 18:29
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 11, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17381

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 8 Awaiting Approval

As of commit e5612e5 with merge base 6e31609 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 11, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an outdated warning from the “building from source” documentation that claimed certain ExecuTorch Python modules were not importable when installed in editable mode (pip -e), reflecting that the underlying issue has been resolved.

Changes:

  • Deleted the warning block that referenced issue #9558 and suggested an import workaround for editable installs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nil-is-all nil-is-all added the module: doc Issues related to documentation, both in docs/ and inlined in code label Feb 11, 2026
@mohammed-saalim
Copy link
Contributor Author

is there something i should work on? @larryliu0820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: doc Issues related to documentation, both in docs/ and inlined in code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the outdated warning in building from source documentation

3 participants