Remove outdated editable mode warning from docs#17381
Remove outdated editable mode warning from docs#17381mohammed-saalim wants to merge 2 commits intopytorch:mainfrom
Conversation
The warning about modules not being importable directly in editable mode is no longer relevant, as the issue has been resolved. Direct imports like 'from executorch.exir import CaptureConfig' now work correctly in editable mode. Fixes pytorch#11229
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17381
Note: Links to docs will display an error until the docs builds have been completed.
|
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Removes an outdated warning from the “building from source” documentation that claimed certain ExecuTorch Python modules were not importable when installed in editable mode (pip -e), reflecting that the underlying issue has been resolved.
Changes:
- Deleted the warning block that referenced issue #9558 and suggested an import workaround for editable installs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
is there something i should work on? @larryliu0820 |
Summary
Removed outdated warning about modules not being importable directly in editable mode, as this issue has been resolved.
Changes
docs/source/using-executorch-building-from-source.mdfrom executorch.exir import CaptureConfignow work correctly in editable modeContext
The warning referenced issue #9558 which has since been fixed. The workaround is no longer necessary.
Fixes #11229
Supersedes #11245
cc @larryliu0820 @mergennachin @byjlw