NXP backend: Add support for aten.avg_pool1d.default.#17412
Open
MartinPavella wants to merge 2 commits intopytorch:mainfrom
Open
NXP backend: Add support for aten.avg_pool1d.default.#17412MartinPavella wants to merge 2 commits intopytorch:mainfrom
aten.avg_pool1d.default.#17412MartinPavella wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17412
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit ce9a9ed with merge base c09db81 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
The changes are based on another PR (#16540) so only the last commit is relevant. |
7984709 to
ce9a9ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the conversion from aten dialect to edge dialect, ExecuTorch replaces the
avg_pool1dwithavg_pool_2dand adds anaten,unsqueezebefore, to introduce the 4th dimension of size 1, and anaten.squeezeis added after to remove it. Theavg_pool1dis then supported by the existingAvgPool2DConverter.Test plan
Unit-tests provided.
cc @robert-kalmar @JakeStevens @digantdesai