Fix out-of-bounds write in Cadence HiFi bmm bias buffer initialization#17453
Fix out-of-bounds write in Cadence HiFi bmm bias buffer initialization#17453rascani merged 1 commit intopytorch:mainfrom
Conversation
The temporary zero-bias buffer for xa_nn_matmul_f32xf32_f32 was being
"initialized" by writing a single zero one element past the end of the
allocation (`tmp[batch_size * m * p] = {0}`). Replace with memset to
correctly zero the entire buffer, and use sizeof(FLOAT32) consistently.
This diff was authored with the help of Claude.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17453
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 3 Unrelated FailuresAs of commit b567cd6 with merge base c12dc35 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
mcremon-meta
left a comment
There was a problem hiding this comment.
cc @dijopaul and @cad-audio
|
Failures unrelated. |
Summary
The temporary zero-bias buffer for xa_nn_matmul_f32xf32_f32 was being "initialized" by writing a single zero one element past the end of the allocation (
tmp[batch_size * m * p] = {0}). Replace with memset to correctly zero the entire buffer, and use sizeof(FLOAT32) consistently.This diff was authored with the help of Claude.
Test plan
CI