Add cortex_m visibility to portable kernel utilities#17456
Add cortex_m visibility to portable kernel utilities#17456Ninja91 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17456
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit e2257f3 with merge base 6e31609 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary: Add cortex_m backends to visibility for kernel utilities that cortex_m operators depend on: - copy_ops_util - kernel_ops_util - padding_util This enables cortex_m operators to import these utilities when building for ARM embedded platforms. Differential Revision: D93254993
There was a problem hiding this comment.
Pull request overview
This PR adds cortex_m backend visibility to three portable kernel utilities that are needed by cortex_m operators when building for ARM embedded platforms. The changes enable the cortex_m backend to properly access these utility libraries during build.
Changes:
- Added
//executorch/backends/cortex_m/...visibility tocopy_ops_util,kernel_ops_util, andpadding_util
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
95fde19 to
d5afdfd
Compare
Summary: Add cortex_m backends to visibility for kernel utilities that cortex_m operators depend on: - copy_ops_util - kernel_ops_util - padding_util This enables cortex_m operators to import these utilities when building for ARM embedded platforms. Differential Revision: D93254993
Summary: Add cortex_m backends to visibility for kernel utilities that cortex_m operators depend on: - copy_ops_util - kernel_ops_util - padding_util This enables cortex_m operators to import these utilities when building for ARM embedded platforms. Differential Revision: D93254993
d5afdfd to
0adcb2b
Compare
Summary: Add cortex_m backends to visibility for portable kernel utilities that cortex_m operators depend on. ## Context The cortex_m operators (`quantized_linear`, `quantized_conv2d`, `quantized_add`, etc.) require utilities from `//executorch/kernels/portable/cpu/util/` for kernel calculations, tensor operations, and padding. These utilities had restricted visibility that excluded `//executorch/backends/cortex_m/...`, causing build failures when building cortex_m operators for ARM embedded platforms. This diff is part of a stack enabling D92456499 (use `on_device_model.pte` for CC pipeline offline eval). ## Changes Updated visibility for three utility targets: | Utility | Purpose | |---------|---------| | `kernel_ops_util` | Kernel dimension calculations for quantized ops | | `copy_ops_util` | Tensor copy operations | | `padding_util` | Padding calculations for pooling operators | Differential Revision: D93254993
0adcb2b to
e2257f3
Compare
Summary: Add cortex_m backends to visibility for portable kernel utilities that cortex_m operators depend on. ## Context The cortex_m operators (`quantized_linear`, `quantized_conv2d`, `quantized_add`, etc.) require utilities from `//executorch/kernels/portable/cpu/util/` for kernel calculations, tensor operations, and padding. These utilities had restricted visibility that excluded `//executorch/backends/cortex_m/...`, causing build failures when building cortex_m operators for ARM embedded platforms. This diff is part of a stack enabling D92456499 (use `on_device_model.pte` for CC pipeline offline eval). ## Changes Updated visibility for three utility targets: | Utility | Purpose | |---------|---------| | `kernel_ops_util` | Kernel dimension calculations for quantized ops | | `copy_ops_util` | Tensor copy operations | | `padding_util` | Padding calculations for pooling operators | Differential Revision: D93254993
Summary: Add cortex_m backends to visibility for portable kernel utilities that cortex_m operators depend on. ## Context The cortex_m operators (`quantized_linear`, `quantized_conv2d`, `quantized_add`, etc.) require utilities from `//executorch/kernels/portable/cpu/util/` for kernel calculations, tensor operations, and padding. These utilities had restricted visibility that excluded `//executorch/backends/cortex_m/...`, causing build failures when building cortex_m operators for ARM embedded platforms. This diff is part of a stack enabling D92456499 (use `on_device_model.pte` for CC pipeline offline eval). ## Changes Updated visibility for three utility targets: | Utility | Purpose | |---------|---------| | `kernel_ops_util` | Kernel dimension calculations for quantized ops | | `copy_ops_util` | Tensor copy operations | | `padding_util` | Padding calculations for pooling operators | Differential Revision: D93254993
Summary: Add cortex_m backends to visibility for portable kernel utilities that cortex_m operators depend on. ## Context The cortex_m operators (`quantized_linear`, `quantized_conv2d`, `quantized_add`, etc.) require utilities from `//executorch/kernels/portable/cpu/util/` for kernel calculations, tensor operations, and padding. These utilities had restricted visibility that excluded `//executorch/backends/cortex_m/...`, causing build failures when building cortex_m operators for ARM embedded platforms. This diff is part of a stack enabling D92456499 (use `on_device_model.pte` for CC pipeline offline eval). ## Changes Updated visibility for three utility targets: | Utility | Purpose | |---------|---------| | `kernel_ops_util` | Kernel dimension calculations for quantized ops | | `copy_ops_util` | Tensor copy operations | | `padding_util` | Padding calculations for pooling operators | Differential Revision: D93254993
Summary:
Add cortex_m backends to visibility for kernel utilities that cortex_m operators depend on:
This enables cortex_m operators to import these utilities when building for ARM embedded platforms.
Differential Revision: D93254993