Consistent usage in 4-application-development.md#39
Open
adnanvaldes wants to merge 1 commit intorage:mainfrom
Open
Consistent usage in 4-application-development.md#39adnanvaldes wants to merge 1 commit intorage:mainfrom
adnanvaldes wants to merge 1 commit intorage:mainfrom
Conversation
In the Epilogue of Part 10, Section 4, the dependency injection example uses `storage_service` to illustrate the ability to maintain a user interface even when storage locations change.
However, in the example it shows:
```
class PhoneBookApplication:
def __init__(self, filename):
self.__phonebook = PhoneBook()
self.__filename = filename
# the rest of the user interface
# use a different filename
storage_service = FileHandler("new_phonebook.txt")
```
The `PhoneBookApplication` class constructor should continue to use `storage_service` with the filename change only being applied in the name passed to `FileHandler`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Epilogue of Part 10, Section 4, the dependency injection example uses
storage_serviceto illustrate the ability to maintain a user interface even when storage locations change.However, in the example it shows:
The
PhoneBookApplicationclass constructor should continue to usestorage_servicewith the filename change only being applied in the name passed toFileHandler.