This repository was archived by the owner on Dec 29, 2022. It is now read-only.
fix: effect callback called on each render when dimensions have not changed#33
Open
ninjz wants to merge 1 commit intoreact-native-toolkit:masterfrom
Open
fix: effect callback called on each render when dimensions have not changed#33ninjz wants to merge 1 commit intoreact-native-toolkit:masterfrom
ninjz wants to merge 1 commit intoreact-native-toolkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hook
useDimensionsListenerreturns a new object. This results in the hookuseDimensionsChangeto always call theeffectcallback on each render sinceuseDimensionsListener()returns a new object each time.This PR fixes this by using the screen and window properties explicitly as the dependencies for
useEffect.