chore: usage, transition, imperative에 대한 용어집 추가 #1448
Conversation
nayounsang
requested review from
eomttt,
gnujoow,
hg-pyun and
lumirlumir
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Size changesDetails📦 Next.js Bundle Analysis for undefinedThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
CI 실패 한번 확인해주시겠어요? 문서들에 대한 용어 번역도 모두 이 PR에 반영되면 좋을 것 같습니다.
| }, | ||
| }, | ||
| { | ||
| sources: [/\busage\b/i], |
There was a problem hiding this comment.
| sources: [/\busage\b/i], | |
| sources: [/\bUsage\b/], |
현재 구현에서는 i 플래그를 기본적으로 추가하여 검사하고 있기 때문에, i 플래그가 없어도 괜찮을 것 같아요.
ko.react.dev/textlint/rules/translateGlossary.js
Lines 24 to 25 in 9123887
그리고 로직과는 상관 없지만 앞선 다른 정규표현식들이 모두 맨 첫 문자를 대문자로 표기했기에, 대문자 U로 정규식을 시작하면 더 좋을 것 같습니다.
| }, | ||
| }, | ||
| { | ||
| sources: [/\btransitions?\b/], |
There was a problem hiding this comment.
| sources: [/\btransitions?\b/], | |
| sources: [/\bTransitions?\b/], |
앞선 리뷰와 동일합니다.
| sources: [/\btransitions?\b/], | ||
| target: '트랜지션', | ||
| meta: { | ||
| term: 'transition', |
There was a problem hiding this comment.
| term: 'transition', | |
| term: 'Transition', |
| }, | ||
| }, | ||
| { | ||
| sources: [/\bimperative\b/], |
There was a problem hiding this comment.
| sources: [/\bimperative\b/], | |
| sources: [/\bImperative\b/], |
| sources: [/\bimperative\b/], | ||
| target: '명령형', | ||
| meta: { | ||
| term: 'imperative', |
There was a problem hiding this comment.
| term: 'imperative', | |
| term: 'Imperative', |
| }, | ||
| { | ||
| sources: [/\busage\b/i], | ||
| target: '용법', |
There was a problem hiding this comment.
2 participants
close #1425
usage, transition, imperative에 대한 용어집 추가
usage는 제목에 올 수 있는 만큼 대소문자 구분을 하지 않고
transition은 명사인 만큼 s 역시도 검사합니다.
필수 확인 사항
textlint가이드Textlint Guide선택 확인 사항