chore: update ArgoCD validation rules and bump dependencies #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akhil nittala <nakhil@redhat.com>
akhilnittala
force-pushed
the
usr/akhil/GITOPS-8560_ValidationMarkerChanges
branch
from
b509227 to
5e4244f
Compare
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anandf
approved these changes
Jan 27, 2026
Contributor
Author
|
/retest-required |
Member
|
/retest |
4 tasks
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
When both sso and oidc config is provided in argocd, we are not rejecting the request. so with this pr changes, we have implemented validation which rejects the request with argocd CR having both sso and oidc configuration.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-8560
Fixes #?
https://issues.redhat.com/browse/GITOPS-8560
Test acceptance criteria:
How to test changes / Special notes to the reviewer: