fix #370: run deployment_bastion_node_cleanup only on the same server uuid#371
Open
ioggstream wants to merge 1 commit intoredhat-openstack:masterfrom
Open
fix #370: run deployment_bastion_node_cleanup only on the same server uuid#371ioggstream wants to merge 1 commit intoredhat-openstack:masterfrom
ioggstream wants to merge 1 commit intoredhat-openstack:masterfrom
Conversation
Contributor
|
I'm going to see if I can try this this week. it may be that this also solves the problem with a stack delete hanging. |
Contributor
Author
|
@markllama great. Please let me know if you need any kind of support. Feel free to email:robipolli@gmail.com / irc:ioggstream me. |
… the same server uuid.
825021d to
88d0dbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch should fix the very annoying #370
Before unregistering the node it checks if the server uuid attached to the OS::Heat::DeploymentConfig is the same of the target machine.
As the ip address could be reused in time (eg. if the server is removed instead of just marked unhealthy) I used the server uuid, relying on
Feedback welcome + Peace,
R: