Conversation
Contributor
|
Good improvement on running some tests before dispatching. I think we can skip the heavy tests and/or run them in private repository which is always a superset of tests. Instead of using workflow_run as a trigger I believe we want to use https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows instead? I don't like the workflow trigger because it has an implicit trigger chain across the workflow yamls. |
weeco
reviewed
Jan 5, 2026
Comment on lines
4
to
7
| workflow_run: | ||
| workflows: ["Backend verify", "Frontend Lint & Compile check"] | ||
| types: | ||
| - completed |
Contributor
There was a problem hiding this comment.
I'd suggest to keep the trigger and use https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows for invoking the test/lint workflows to keep the trigger self-contained in this file.
Addressed code review feedback to make the workflow self-contained by: - Making backend-lint-test.yml and frontend-verify.yml reusable with workflow_call trigger - Calling both workflows as jobs in repository-dispatch.yml - Using 'needs' to ensure dispatch only runs after tests pass This keeps the trigger self-contained in one file while still ensuring tests pass before dispatching to console-enterprise. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
weeco
approved these changes
Jan 8, 2026
malinskibeniamin
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should first run some tests before we bump console enterprise.