Improves scannability of pipelines list page for faster troubleshooting#2234
Draft
eblairmckee wants to merge 5 commits intomasterfrom
Draft
Improves scannability of pipelines list page for faster troubleshooting#2234eblairmckee wants to merge 5 commits intomasterfrom
eblairmckee wants to merge 5 commits intomasterfrom
Conversation
Extract STARTABLE_STATES, STOPPABLE_STATES, TRANSITIONAL_STATES, and PIPELINE_STATE_OPTIONS to ui/pipeline/constants.ts. Replace icon-based status badge with pulsing dot indicator at ui/pipeline/status-badge.tsx. Delete old status-badge.tsx and update import path. RED-9 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add enableSmartPolling option that auto-refetches the pipeline list every 2s when any pipeline is in STARTING or STOPPING state. Works with the existing infinite query pagination approach. RED-9 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace ID/Description columns with Input/Output connector badges parsed from pipeline configYaml. Add dropdown action menu with context-aware Edit, Start, Stop, Retry Start/Stop, and Delete actions. Enable smart polling for transitional pipeline states. RED-9 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
+33
to
+71
| const statusConfig = useMemo(() => { | ||
| switch (state) { | ||
| case Pipeline_State.RUNNING: | ||
| return { | ||
| icon: <PulsingStatusIcon variant="success" />, | ||
| text: 'Running', | ||
| }; | ||
| case Pipeline_State.STARTING: | ||
| return { | ||
| icon: <PulsingStatusIcon variant="warning" />, | ||
| text: 'Starting', | ||
| }; | ||
| case Pipeline_State.STOPPING: | ||
| return { | ||
| icon: <PulsingStatusIcon variant="warning" />, | ||
| text: 'Stopping', | ||
| }; | ||
| case Pipeline_State.STOPPED: | ||
| return { | ||
| icon: <PulsingStatusIcon pulsing={false} variant="disabled" />, | ||
| text: 'Stopped', | ||
| }; | ||
| case Pipeline_State.COMPLETED: | ||
| return { | ||
| icon: <PulsingStatusIcon variant="success" />, | ||
| text: 'Completed', | ||
| }; | ||
| case Pipeline_State.ERROR: | ||
| return { | ||
| icon: <PulsingStatusIcon variant="error" />, | ||
| text: 'Error', | ||
| }; | ||
| default: | ||
| return { | ||
| icon: <PulsingStatusIcon variant="informative" />, | ||
| text: 'Unknown', | ||
| }; | ||
| } | ||
| }, [state]); |
Contributor
There was a problem hiding this comment.
I don't think we need useMemo here. We can just take it out of the component layer?
Comment on lines
+108
to
+112
| const hasTransitional = pages?.some((page) => | ||
| page?.response?.pipelines?.some( | ||
| (p) => p?.state === Pipeline_State.STARTING || p?.state === Pipeline_State.STOPPING | ||
| ) | ||
| ); |
Contributor
There was a problem hiding this comment.
[small nit]: I would make a list of states we want to enable polling for, and just check with .includes()
|
|
||
| .cursor No newline at end of file | ||
| .cursor | ||
| .claude/skills No newline at end of file |
Contributor
There was a problem hiding this comment.
Do we want to ignore all claude skills?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the pipeline list page to improve scannability and debugging UX.
What changed
Added filters
Added more columns
UI registry changes
This branch includes draft versions of new ui-registry components that will be upstreamed in a separate PR and then reinstalled here:
These changes should be ignored in this review — they'll come in via ui-registry once upstreamed.
Files changed (excluding ui-registry)