test_bornagain upgrade to BornAgain-22#81
Open
jwuttke wants to merge 1 commit intoreflectivity:masterfrom
Open
test_bornagain upgrade to BornAgain-22#81jwuttke wants to merge 1 commit intoreflectivity:masterfrom
jwuttke wants to merge 1 commit intoreflectivity:masterfrom
Conversation
Collaborator
|
@jwuttke, the test suite is currently failing for this changeset. The lint issues are easily sorted. However, there's several numerical fails in the reflectivity kernel comparison. Can you investigate and see if it's a test tolerance that needs to be relaxed, or if there's something needs inspecting in BornAgain? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated scripts executes under BornAgain-22.
However, the simulation model had to be modified, making it more meaningful and causing changes in the expected outcome.
Previously, the script had hurst=0, which implied no scattering from the interface. v22 no longer allows for hurst parameter and correlation length of 0. Therefore nonzero values have been chosen here.
See also https://jugit.fz-juelich.de/mlz/bornagain/-/issues/1165.