Fix for 'dirty' error caused by scroll notifications during layout#14
Open
PatrickWulfe wants to merge 2 commits intorickypid:masterfrom
Open
Fix for 'dirty' error caused by scroll notifications during layout#14PatrickWulfe wants to merge 2 commits intorickypid:masterfrom
PatrickWulfe wants to merge 2 commits intorickypid:masterfrom
Conversation
|
Hi @PatrickWulfe , I tried to reproduce your scenario using the modal_bottom_sheet package. I use their example and I put the ScrollShadow above the ListView in ModalInsideModal class. In the application you find it in the "Bar Modal" example. My simple code is the following: Thank you |
Owner
|
Hi @PatrickWulfe, Do you have any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the widget was rebuilt, (by calling a modal bottom sheet in my case), and a scroll notification happened during that rebuild, you would receive a dirty state error. By moving the setStates to a microtask, it avoids this error.