Fix display.launch.py default model path handling #85
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the urdf_tutorial on a newer setup (ROS 2 Kilted on Ubuntu 24.04),
launching the tutorial failed unless the model path was manually prefixed with
urdf/.The issue was caused by the default
modellaunch argument being constructedusing a PathJoinSubstitution and then stringified. On newer ROS 2 / Python
versions, LaunchArgument defaults are treated strictly as strings, which led to
invalid URDF paths being passed to xacro.
This change:
modelargumenturdf/directory at the tutorial level when invoking urdf_launchThis keeps urdf_launch generic while fixing the tutorial’s default behavior and
avoids requiring users to manually adjust paths.
Tested on ROS 2 Kilted (Ubuntu 24.04).