perf: Optimized out shared_ptr copies#3079
Draft
jmachowinski wants to merge 1 commit intoros2:rollingfrom
Draft
Conversation
Collaborator
Author
|
Pulls: #3079
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a PR that aims to eliminate overhead by unneeded copies of shared ptrs all over the code.
ATM this is a draft as it might touch external interfaces and beak user code down the line.
Fixes # (issue)
Is this user-facing behavior change?
Yes, as in theory it is an API change, but in most cases the end user will not notice it.
Did you use Generative AI?
I wish I had...