Closed
Conversation
This brings in a new major version of v8 and Various tweaks are needed: - upgrade the CI images to get a toolchain capable of compiling V8 - upgrade the macos image to macos-15-xlarge because the non-xlarge runner does not have enough memory - compile without debug info on the macos runner, otherwise it runs out of free disk space - patch a header file to pacify clang - link in V8's new dependencies abseil, highway and simdutf - disable ccache because it does not seem to play well with V8 anymore and is not otherwise useful for building on CI (hit rate: 0%)
bnoordhuis
force-pushed
the
node-24
branch
2 times, most recently
from
df1a77e to
6101402
Compare
pento
reviewed
Jun 26, 2025
| fail-fast: false | ||
| matrix: | ||
| platform: | ||
| - x86_64 |
Contributor
There was a problem hiding this comment.
Why is this removed? Apple have announced that Intel support is going away in future macOS versions, but it isn't dead yet. 😉
Contributor
There was a problem hiding this comment.
Oh, lol. GitHub made macos-14+ intel runners only available on Team/Enterprise plans. Never mind. 🙃
Collaborator
Author
|
@SamSaffron gentle ping? |
Collaborator
|
Hi Ben 🤗 I merged this all by hand and did a new release of 24 with mini_racer Also @pento built the intel mac package so I published it. |
Collaborator
Author
Nice, good job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings in a new major version of v8 and Various tweaks are needed:
upgrade the CI images to get a toolchain capable of compiling V8
upgrade the macos image to macos-15-xlarge because the non-xlarge runner does not have enough memory
compile without debug info on the macos runner, otherwise it runs out of free disk space
patch a header file to pacify clang
link in V8's new dependencies abseil, highway and simdutf
disable ccache because it does not seem to play well with V8 anymore and is not otherwise useful for building on CI (hit rate: 0%)