Skip to content

Handle JSON generation like other errors instead of bailing out#3218

Closed
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
GuillaumeGomez:json-err-handling
Closed

Handle JSON generation like other errors instead of bailing out#3218
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
GuillaumeGomez:json-err-handling

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 1, 2026

I tested one of the failed crate on docs.rs and couldn't reproduce the bug locally, so I assume the build could be retried and therefore this error should be handled like the others.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner March 1, 2026 19:35
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Mar 1, 2026
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my original reasoning was that the json build might crash and I wouldn't want to have the html build failing when we only have a rustdoc-json bug/crash.

Or do you think it's stable enough now?

I tested one of the failed crate on docs.rs and couldn't reproduce the bug locally, so I assume the build could be retried and therefore this error should be handled like the others.

Was there a different nightly version for the initial build and the re-run? Or the same and just re-running was what's needed?

View changes since this review

@syphar
Copy link
Member

syphar commented Mar 2, 2026

Also the tests fail for proc-macro crates, remembering now that there was an edge case about json&proc-macros I don't remember?

@GuillaumeGomez
Copy link
Member Author

Let's keep things as is then. I saw an issue in sentry listing this but maybe I misunderstood the problem. Anyway, closing. :)

@GuillaumeGomez GuillaumeGomez deleted the json-err-handling branch March 2, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants