Skip to content

Rollup of 3 pull requests#153832

Merged
rust-bors[bot] merged 6 commits intorust-lang:mainfrom
matthiaskrgr:rollup-tOzZz0L
Mar 13, 2026
Merged

Rollup of 3 pull requests#153832
rust-bors[bot] merged 6 commits intorust-lang:mainfrom
matthiaskrgr:rollup-tOzZz0L

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Mar 13, 2026

Successful merges:

r? @ghost

Create a similar rollup

zachs18 and others added 6 commits March 12, 2026 18:52
@zachs18
Remove PointerLikeCandidate
814c750
@softmoth
core: lift FIXME comment from option.rs to iter::try_process
ea674ec 
This FIXME is relevant not only to Option but other similar cases that
use iter::try_process(). The referenced issue 11084 was closed in 2021,
and the related PR 59605 was not merged due to inconclusive results.
@abh1nav10
Fix grammar in Pin documentation
4916314
@matthiaskrgr
Rollup merge of rust-lang#153418 - softmoth:patch-1, r=joboet
12d320f 
core: remove FIXME comment in option.rs FromIterator

The referenced issue rust-lang#11084 was closed in 2021, and the related PR rust-lang#59605 was not merged due to inconclusive results. Similar code (in result.rs, for example) doesn't have this FIXME comment; this is the only reference to issue 11084 (or pull request 59605).

This FIXME was not mentioned in issue rust-lang#44366.
@matthiaskrgr
Rollup merge of rust-lang#153569 - abh1nav10:fix-pin-docs, r=joboet
42c7f52 
Fix grammar in Pin documentation

Changed "has an address-sensitive" to "has address-sensitive states" in the `Drop` implementation section of the documentation of `Pin` thereby making it grammatically complete.
@matthiaskrgr
Rollup merge of rust-lang#153798 - zachs18:remove-pointerlikecandidat…
cc41ba4 
…e, r=JohnTitor

Remove unused `SelectionCandidate::PointerLikeCandidate`

The `PointerLike` trait was removed in rust-lang#143308, as part of `dyn*` being removed.

`!null` pattern types were added in rust-lang#142339 , which added `SelectionCandidate::PointerLikeCandidate`, IIUC to allow pattern types to implement `PointerLike`, but `PointerLike` was removed after that PR was first written, so (I assume) that functionality was mostly removed on a rebase, but this part didn't get removed. (see an earlier version of that PR that mentioned `LangItem::PointerLike`: rust-lang@50cab82 before it got rebased over the rollup containing 143308: rust-lang#142339 (comment) )

cc @oli-obk
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 13, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 13, 2026
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Mar 13, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 13, 2026

📌 Commit cc41ba4 has been approved by matthiaskrgr

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 13, 2026

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 13m 7s
Pushing 1d8897a to main...

@rust-bors rust-bors bot merged commit 1d8897a into rust-lang:main Mar 13, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f1ceedf (parent) -> 1d8897a (this PR)

Test differences

Show 37 test diffs

37 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1d8897a4e88051480b36c501e66809425c6e08ad --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 1h 24m -> 1h 55m (+36.3%)
  2. dist-aarch64-apple: 1h 58m -> 1h 29m (-24.5%)
  3. pr-check-1: 27m 33s -> 32m 49s (+19.2%)
  4. optional-x86_64-gnu-parallel-frontend: 2h 15m -> 2h 38m (+16.8%)
  5. x86_64-rust-for-linux: 45m 58s -> 53m 36s (+16.6%)
  6. dist-x86_64-apple: 2h 8m -> 1h 48m (-15.0%)
  7. x86_64-gnu-tools: 56m 16s -> 1h 3m (+13.5%)
  8. i686-gnu-1: 2h 7m -> 2h 23m (+12.6%)
  9. x86_64-gnu-llvm-21-1: 1h 7m -> 1h 15m (+12.6%)
  10. i686-gnu-nopt-1: 2h 7m -> 2h 23m (+12.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-bors rust-bors bot mentioned this pull request Mar 13, 2026
Open
@rust-timer
Copy link
Collaborator

rust-timer commented Mar 13, 2026

Finished benchmarking commit (1d8897a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.1%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.9% [3.6%, 4.2%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -4.6% [-4.6%, -4.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.0% [-4.6%, 4.2%] 3

Cycles

Results (primary 0.1%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)		 2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 -3.8% [-3.8%, -3.8%] 1
All ❌✅ (primary) 0.1% [-2.3%, 2.6%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 478.63s -> 480.71s (0.43%)
Artifact size: 394.82 MiB -> 394.85 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr @rust-timer @rustbot @zachs18 @softmoth @abh1nav10