Conversation
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
|
r? rustc-dev-guide |
|
In my opinion, it would be meaningless to just change the date without changing the content. If there is a change in the content, please update the date then |
| @@ -1,6 +1,6 @@ | |||
| # Updating LLVM | |||
|
|
|||
| <!-- date-check: Aug 2024 --> | |||
There was a problem hiding this comment.
I believe this date-check is left over from when this used to hard-code LLVM versions. There's nothing here anymore that's version specific so I think we can just remove this date-check altogether rather than updating it.
|
|
||
| ## New LLVM Release Updates | ||
|
|
||
| <!-- date-check: Jul 2023 --> |
There was a problem hiding this comment.
ditto, I think we can remove this.
| > - [LLVM 17](https://github.com/rust-lang/rust/pull/115959) | ||
| > - [LLVM 18](https://github.com/rust-lang/rust/pull/120055) | ||
| > - [LLVM 19](https://github.com/rust-lang/rust/pull/127513) | ||
| > - [LLVM 20](https://github.com/rust-lang/rust/pull/135763) |
There was a problem hiding this comment.
could you add a link to rust-lang/rust#143684 and rust-lang/rust#150722 here please?
| ## Choices are always lifetime parameters | ||
|
|
||
| At present, the "choice" regions from a member constraint are always lifetime | ||
| parameters from the current function. As of <!-- date-check --> October 2021, | ||
| parameters from the current function. As of <!-- date-check --> March 2026, | ||
| this falls out from the placement of impl Trait, though in the future it may not | ||
| be the case. We take some advantage of this fact, as it simplifies the current | ||
| code. In particular, we don't have to consider a case like `'0 member of ['1, | ||
| 'static]`, in which the value of both `'0` and `'1` are being inferred and hence | ||
| changing. See [rust-lang/rust#61773][#61773] for more information. |
There was a problem hiding this comment.
@BoxyUwU do you happen to know if this is still true?
| As of <!-- date-check --> Aug 2022, | ||
| As of <!-- date-check --> March 2026, | ||
| we lint against direct declarations without the use of the macro. |
There was a problem hiding this comment.
have you verified this is still true?
@reddevilmidzy this isn't how date-check works, see https://rustc-dev-guide.rust-lang.org/contributing.html#contributing-to-rustc-dev-guide |
jyn514
added
S-waiting-on-author
4 participants
Updated 'date-checlk: ' dates in following documents
Signed off by: ko496